Format previous line on 'Enter' key #43
Conversation
|
Great start! Though when having the following code, formatting lead to losing the indentation: SomeType()
.doSomething ( )
// was formatted to
SomeType()
.doSomething()I suppose for non-empty lines we should advance the range to the first non-whitespace character. |
This looks like a swiftformat issue -- I don't think there is a workaround. Added it to the end of nicklockwood/SwiftFormat#1738. I don't think we can make this change in the extension until swiftformat fixes the corresponding issue, otherwise it may be too disruptive for users. |
|
@vinocher-bc ppssibly we can see how many spaces are at beginning of the line before format, and add them back after the format too each new line of the formatted text? |
|
Is this ready to merge now as nicklockwood/SwiftFormat#1738 has been resolved? |
3 participants
When the 'Enter' key is pressed, format the previous line because the user has usually moved to a new empty line. This is the most common scenario.
Also, format only the previous line instead of the entire document for better performance and because formatting the entire doc may conflict with
"editor.formatOnSaveMode": "modifications"(See Only format modified text.)Previously, the entire document was formatted if the new line was non-empty.